-
Notifications
You must be signed in to change notification settings - Fork 23
test: Add Testcontainers and Gherkin execution for our test-harness #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Testcontainers and Gherkin execution for our test-harness #101
Conversation
47f827d to
ff96b1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 90.55% 93.52% +2.96%
==========================================
Files 8 12 +4
Lines 180 463 +283
==========================================
+ Hits 163 433 +270
- Misses 17 30 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ff96b1f to
6749d83
Compare
|
None of the evaluations are working because I get a GRPC.unavailable error when I try to resolve them. This might be related to the open issues. @toddbaert @beeme1mr fyi |
Signed-off-by: Simon Schrottner <[email protected]>
6749d83 to
7fbc770
Compare
|
@aepfli what issue are you referring to? |
nvm I found the issue, the docker container took longer than expected to be available - now there are only 4 test cases missing, and we run the basic test suite as we do for js for the rpc provider - reconnect is something which i will do at a later stage |
3408e94 to
78ef2a6
Compare
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a section in the contributing doc that explains how to run the e2e tests?
So far, the command has not changed for execution. It runs with |
ee32cd7 to
feca070
Compare
Signed-off-by: Simon Schrottner <[email protected]>
feca070 to
7c809e8
Compare
d1b47e6 to
3da62a3
Compare
3da62a3 to
4d4f753
Compare
|
Ready to be reviewed @toddbaert @beeme1mr @open-feature/sdk-python-approvers @open-feature/sdk-python-maintainers |
Signed-off-by: Simon Schrottner <[email protected]>
4d4f753 to
90526fe
Compare
providers/openfeature-provider-flagd/tests/e2e/flagd_container.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/tests/e2e/test_in-process-file.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <[email protected]>
providers/openfeature-provider-flagd/tests/e2e/flagd_container.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/tests/e2e/flagd_container.py
Outdated
Show resolved
Hide resolved
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagD -> flagd but otherwise approved, and very grateful! 🙏
Signed-off-by: Simon Schrottner <[email protected]>
renamed - but we always pronounce it "flag D" else it looks more like "flagged" - just my few cents |
|
This pull request adds a gherkin runner with test containers
This approach:
Issues detected during this implementation
test_rpc.pyare overwrittentest_rpc.pyare overwritten